Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .read command #71

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Add .read command #71

merged 1 commit into from
Aug 17, 2019

Conversation

shwnchpl
Copy link

@shwnchpl shwnchpl commented Aug 15, 2019

Description

Adds the .read command present in the CLI distributed with SQLite3 to allow for SQL "scripts" containing schemata etc. to be loaded from files.

Checklist

  • I've added this contribution to the CHANGELOG file.
  • I've added my name to the AUTHORS file (or it's already there).
    (Neither of these files seem to exist, so I've done neither of these things.

@amjith
Copy link
Member

amjith commented Aug 15, 2019

@shwnchpl The PR looks good.

Would you mind running Black on the code and adding your name to the AUTHORS file?
If you can describe the change in the changelog, I'd appreciate it.

@shwnchpl
Copy link
Author

@shwnchpl The PR looks good.

Would you mind running Black on the code...

I can do that.

...and adding your name to the AUTHORS file?

I might be missing something, but I don't see an AUTHORS file anywhere in this repo.

If you can describe the change in the changelog, I'd appreciate it.

Is that changelog.md? I'm not 100% clear on where/how I should add an entry, since I'm not sure what release version this change will be a part of. It also looks like a merge conflict got committed in that file. I can resolve the conflict and describe this change in a way that seems appropriate to me, if that works.

@amjith
Copy link
Member

amjith commented Aug 15, 2019

@shwnchpl I am so sorry. I have now fixed the pull request template.

The changelog.md file is now updated with sections for future release. We don't have AUTHORS file anymore.

Thank you for pointing that out. 😞

@codecov-io
Copy link

Codecov Report

Merging #71 into master will decrease coverage by 0.6%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   68.19%   67.58%   -0.61%     
==========================================
  Files          21       21              
  Lines        1330     1339       +9     
==========================================
- Hits          907      905       -2     
- Misses        423      434      +11
Impacted Files Coverage Δ
litecli/packages/special/dbcommands.py 20.87% <11.11%> (-1.08%) ⬇️
litecli/encodingutils.py 46.66% <0%> (-13.34%) ⬇️
litecli/packages/completion_engine.py 87.17% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7947e9...4715256. Read the comment docs.

@shwnchpl
Copy link
Author

We don't have AUTHORS file anymore.

Actually, it looks like the mistake was mine. I found the AUTHORS file; it's in the litecli directory. I fixed the style error in dbcommands.py, updated the change log, and added my name to the AUTHORS file.

Sorry about the confusion! 😄

@amjith
Copy link
Member

amjith commented Aug 17, 2019

Looks good. Thank you for the PR.

🍨

@amjith amjith merged commit fbcd425 into dbcli:master Aug 17, 2019
@shwnchpl
Copy link
Author

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants