-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .read command #71
Conversation
@shwnchpl The PR looks good. Would you mind running Black on the code and adding your name to the AUTHORS file? |
I can do that.
I might be missing something, but I don't see an AUTHORS file anywhere in this repo.
Is that changelog.md? I'm not 100% clear on where/how I should add an entry, since I'm not sure what release version this change will be a part of. It also looks like a merge conflict got committed in that file. I can resolve the conflict and describe this change in a way that seems appropriate to me, if that works. |
@shwnchpl I am so sorry. I have now fixed the pull request template. The changelog.md file is now updated with sections for future release. We don't have AUTHORS file anymore. Thank you for pointing that out. 😞 |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 68.19% 67.58% -0.61%
==========================================
Files 21 21
Lines 1330 1339 +9
==========================================
- Hits 907 905 -2
- Misses 423 434 +11
Continue to review full report at Codecov.
|
Actually, it looks like the mistake was mine. I found the AUTHORS file; it's in the litecli directory. I fixed the style error in dbcommands.py, updated the change log, and added my name to the AUTHORS file. Sorry about the confusion! 😄 |
Looks good. Thank you for the PR. 🍨 |
Thanks! 😊 |
Description
Adds the .read command present in the CLI distributed with SQLite3 to allow for SQL "scripts" containing schemata etc. to be loaded from files.
Checklist
CHANGELOG
file.AUTHORS
file (or it's already there).(Neither of these files seem to exist, so I've done neither of these things.